Restored rendering for railway=platform + covered=yes

[map-per]

Fixes #4008

Changes proposed in this pull request:

• Restored rendering for railway=platform + covered=yes

Test rendering with links to the example places:
https://www.openstreetmap.org/way/160042477 (left before, right after)

[map-per]

Is there anything I can do to move this pullrequest forward?

[map-per]

@pnorman & @imagico: Is @jeisenbe still active and doing reviews?

[map-per]

Can someone please review this (@pnorman & @imagico)

[imagico]

I am sorry it took us so long to review this.

The main reason is probably that the style is quite a mess w.r.t. the whole subject of multilayered transportation infrastructure complexes and none of us seems very keen to touch that.

As @jeisenbe commented in #4008 (comment) the change hiding railway=platform + covered=yes was an ad-hoc change made without consensus on a bigger strategy.

I would be fine in principle with restoring specifically display of railway=platform + covered=yes, even if that is kind of another ad-hoc change on top of this because it indeed seems that hiding based on this tag specifically is highly problematic for mapper feedback.

However, i think this should fix at least the main inconsistencies in selective hiding of features and not introduce any new inconsistencies. Here is how current master renders the various variants:

And here how this change affects this:

The inconsistencies between linear way and polygon mapping should be resolved. I also would prefer it if we would treat highway=platform and railway=platform identically - but i am not tied to that.

Beyond that - we really need to develop an overall strategy how to handle multilevel transportation complexes and mapping of multi-level and underground features in those. How such a strategy can look like will depend on how much additional complexity we are willing to accept to accommodate that in the style and i am not sure if we are able to achieve consensus on that.

[map-per]

Thanks for the review

[map-per]

Ok, resolved the inconsistencies for railway=platform. Now linear platforms with covered=yes are displayed and platforms with location=underground are hidden.

Examples

Platform with covered=yes and without tunnel=yes or location=underground is shown (https://www.openstreetmap.org/way/166482810)

Platform with location=underground is not shown (https://www.openstreetmap.org/way/432808388)

Platform with location=underground and tunnel=yes not shown (https://www.openstreetmap.org/way/432808388)

[imagico]

Works as intended now:

And as said above i see this as a definitive improvement.

[map-per]

Great, can you merge it? Or are you waiting for others to review the PR as well?

[map-per]

🎉