-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render leisure=bleachers
ways.
#4985
base: master
Are you sure you want to change the base?
Conversation
Discussion held in gravitystorm#3140 suggested `leisure=bleachers` rendering could be similar in style to pedestrian areas or other human-access features. That is precisely what this patch does. Colors were chosen to be those of `highway=pedestrian` because they are pretty neutral; as `leisure=bleachers` can be used in a number of contexts (such as sport pitches and outdoor theaters), I believe this reduces potential visual confusion. Note that it only renders ways; though found in the wild, `leisure=bleachers` nodes are not supposed to be used.
Thank you for the pull request. I see two issues with this at the moment: First: While Second: Rendering in color identical to The lack of an established tagging to indicate the direction of bleachers makes a good rendering difficult - though heuristics based on the polygon shape could work in many cases. This would be pretty advanced stuff of course so i am hesitant to suggest it. Bottom line: To deal with the first issue you would need to look at both In terms of design: It might be useful to look at other features similar in nature (as engineered structures) and meaning for the map user we currently render: |
Thank you for your well crafted and detailed reply. I do see a semantic difference between Grandstands tend to be large infrastructures with seating on top of them, often with amenities at lower levels (such as toilets, locker rooms, shops and concession stands). Depicting them as buildings makes sense, after all they are conceptually similar to run-of-the-mill buildings with lounge chairs on their roof's sun deck. Bleachers are closer to a tightly knit collection of park benches large enough to deserve an area (instead of just a node). Like you, I'm not convinced those distinctions matter enough for them to be drawn differently when depicted on a map. But I'm on the fence on this, I wouldn't be shocked if they were slightly different. As of now, grandstands are not specifically styled; they inherit the generic A concept similar to bleachers, That long preamble leaves us with those scenarios: ① Draw ② Draw
Both bleachers and grandstands appear to belong in the same family, yet they are subtly different. Fill colors are not exactly the same; bleachers are pure white, grandstands are I'm not fond of TT's bleachers icon which is too busy for my taste and reminds me of a beehive (and the wrong size anyway). In light of what's been discussed so far, would you be in favor of a new patch set that mimicks the Tracestrack approach, with a specific outline coloring for grandstands (peach?), plus a (new) 14×14 icon for bleachers? Bleachers could reuse the (Please suggest otherwise if I'm talking nonsense; I'm really not attached to any particular style, but I do want this issue to find a resolution, it's been lingering for ages in the ticket queue, and 20K useful features are currently not shown on the map and creating “blind spot areas” in parks all around the world). (As for heuristics, I do not think a sufficient success rate can be reasonably achieved. Trying to automagically determine a direction for bleachers/grandstands would likely fail most of the time; most bleachers and grandstands I've seen in OSM are four-point rectangles — assuming a direction using the longest side for those would yield a high failure rate. Trying to determine the closest “feature” — such as sport pitch, outdoor theatre, racetrack — to get some sense of orientation would be computationally expensive and also fail in a significant number of cases.) |
Regarding semantic differences please consider: We are not looking at the difference between the English language terms Grandstand and Bleachers. Neither are we interested in how mappers think the tags should be used differently. The only thing that truly matters for us is the practical use of the tags in OSM. It is hard to properly assess this without local knowledge of the areas you look at - but as said, from a quick look at the data it is quite clear there is a huge overlap in the semantic domains of use of the two tags. One relatively clear difference i could see is that The way to proceed here is - as already hinted at a bit - to
What solutions might work on 2. is hard to say without having a clear picture on 1. Looking for inspiration in other map is always something you can try - but only in the sense of seeking inspiration, not in the sense of copying design. Static point symbols will not work too well because
There are other options like tiled patterns or single symbol patterns.
As said: A more concrete discussion on design will only be possible if we have a clear picture on point 1. But the difference in rendering will evidently be the key here, because - as said - only if we can come up with a differentiated design concept for both that provides mappers with meaningful feedback on both and their difference in meaning (which - as indicated - seems not very pronounced) we can really think about rendering in this style IMO. |
Discussion held in
#3140 suggested
leisure=bleachers
rendering could be similar in style to pedestrian areas or other human-access features.That is precisely what this patch does.
Colors were chosen to be those of
highway=pedestrian
because they are pretty neutral; asleisure=bleachers
can be used in a number of contexts (such as sport pitches and outdoor theaters), I believe this reduces potential visual confusion.Note that it only renders ways; though found in the wild,
leisure=bleachers
nodes are not supposed to be used.Fixes # 3140
Changes proposed in this pull request:
leisure=bleachers
ways.Test rendering with links to the example places:
Case 1: bleachers for sport pitches, at https://www.openstreetmap.org/#map=18/45.58160/-73.55462 — notice the bleachers on the bottom baseball field and near the soccer pitch.
Before
After
Case 2: bleachers around the Montreal F1 race track, at https://www.openstreetmap.org/way/459013809#map=18/45.51210/-73.52585 — notice the large bleachers section at the right of the track.
Before
After