Crossroad names

[matthijsmelissen]

Render names on nodes with junction=yes or highway=traffic_signals.

This resolves #374.

[matthijsmelissen]

Example rendering:

[matthijsmelissen]

Rebased.

[matthijsmelissen]

I think we can speed up the merging of pull requests if more people assist in reviewing them. Is anyone interesting in reviewing this pull request?

[sommerluk]

While I cannot do a code review or testing (due to a lack of skills in cartocss), nevertheless here some feedback about what I can see:

• The rendering example looks very good. Using the same font color as for residential roads is reasonable. It does not look overloaded like Google Maps in Japan.
• Concerning traffic signal names: It seems that the name will be rendered starting with zoom level 14, but the icon will be rendered starting with zoom level 17, right? I’m not sure if this is good idea. Would prefer this:
  – if highway=traffic_signals and name=* are both present, than the name and the icon are both rendered starting from zoom level 14.
  – if only highway=traffic_signals is present (without a name=*), than the icon is rendered starting from zoom level 17.
  Otherwise it would be confusing to have the traffic signal names sometimes with and sometimes without their corresponding icon.

[matthijsmelissen]

Concerning traffic signal names: It seems that the name will be rendered starting with zoom level 14, but the icon will be rendered starting with zoom level 17, right? I

I see your point. However, if we only rendered named traffic lights, then some traffic lights would be visible while others wouldn't. I think rendering all traffic lights from z14 is too early.

[sommerluk]

if we only rendered named traffic lights, then some traffic lights would be visible while others wouldn't.

Would this be a big disadvantage or breaking with some styling conventions? For me, this would be exactly what is expected.

I think rendering all traffic lights from z14 is too early.

Agreed.

[sommerluk]

We could even refine this, to catch also the combination of junction=yes + highway=traffic_signals correctly:

• junction=yes + name=* (without highway=traffic_signals): This is a named junction. Starting from z14 render the name.
• highway=traffic_signals + name=* (without junction=yes): This is named traffic signal. Starting from z14 render both: name and icon.
• highway=traffic_signals (without name=* and without junction=yes): This is a traffic signal without a name. Starting from z17 render the icon.
• highway=traffic_signals + name=* + junction=yes: This is a named junction (that has additionally a traffic signal without a name). Like for named junctions, the name is rendered starting with z14, but like for traffic signals without a name, the icon starts with z17.