Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
/ js-client Public archive

Add tags fields for raw/text renderers #315

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

michaelwisely
Copy link
Contributor

We were dropping the Tags field coming from ID:18's for the raw and text renderers.

This PR keeps the tags field, because we need it to do proper tag ID lookups.

@michaelwisely michaelwisely changed the title Add tags fields to raw/text renderers Add tags fields for raw/text renderers May 19, 2022
Copy link
Contributor

@evan-gravwell evan-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isRawSearchMessageReceivedRequestEntriesWithinRangeTextRenderer and isRawSearchMessageReceivedRequestEntriesWithinRangeRawRenderer should probably be kept in sync with these changes.

Copy link
Contributor

@evan-gravwell evan-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code: LGTM!

@evan-gravwell evan-gravwell merged commit 436bf55 into dev May 19, 2022
@michaelwisely michaelwisely deleted the fix/add-tags-to-raw branch May 19, 2022 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants