This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
fix(#336): Can't fetch a template just after creation. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 22e5f8f Author: GeraldHamiltonWicks <[email protected]> Date: Wed Jun 15 16:52:56 2022 -0300 removing useless import commit 7a00017 Author: GeraldHamiltonWicks <[email protected]> Date: Wed Jun 15 16:50:37 2022 -0300 adding spaces commit 9d61747 Author: GeraldHamiltonWicks <[email protected]> Date: Wed Jun 15 16:48:39 2022 -0300 removing logs commit 2e6b530 Author: GeraldHamiltonWicks <[email protected]> Date: Wed Jun 15 16:47:10 2022 -0300 fixing createOneTemplate
…into fix/templates
…into fix/dockerfile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses: #336
Important to say that, the issue was even bigger than what was described on
gitea, so when any template was created, an 400 request was received and didn't go to/templatespage after clicking on the save button. (And probably that's why drone was failing on template tests)issue5082cantAddAnyTemplate.mp4
With the current solution, beyond the fact, that the template is working, and the drone will probably be fixed, now we do one request (create one template) to the back-end instead of two (create one template and get one template).
After the implementation, here is the behavior on the template page (add, edit and delete works correctly):
showingFix336.mp4