Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seo): add initial package scaffold #1633

Merged
merged 5 commits into from
Jun 28, 2021
Merged

feat(seo): add initial package scaffold #1633

merged 5 commits into from
Jun 28, 2021

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Jun 23, 2021 •
edited by damienwebdev
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Purpose

This adds a package as described by #1632

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added the package: seo @daffodil/seo label Jun 23, 2021
@griest024 griest024 requested a review from a team as a code owner June 23, 2021 15:47
@griest024 griest024 requested a review from a team as a code owner June 23, 2021 15:52
damienwebdev
damienwebdev requested changes Jun 23, 2021
View reviewed changes
libs/seo/README.md Outdated Show resolved Hide resolved
libs/seo/package.json Outdated Show resolved Hide resolved
libs/seo/package.json Show resolved Hide resolved
libs/seo/package.json Outdated Show resolved Hide resolved
libs/seo/tsconfig.lib.json Show resolved Hide resolved
damienwebdev
damienwebdev requested changes Jun 28, 2021
View reviewed changes
libs/seo/tsconfig.lib.json Show resolved Hide resolved
libs/seo/tsconfig.lib.json Outdated Show resolved Hide resolved
@damienwebdev
Copy link
Member

Can you add an entry to the contribution guidelines?

@griest024
Copy link
Member Author

Can you add an entry to the contribution guidelines?

added

damienwebdev
damienwebdev approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 36a01b8 into graycoreio:develop Jun 28, 2021
@griest024 griest024 deleted the feat/seo/initial-package branch June 28, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev damienwebdev approved these changes

Assignees
No one assigned
Labels
package: seo @daffodil/seo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@griest024 @damienwebdev