Hydradancer fixes for Facedancer #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
antoinevg
approved these changes
Jun 14, 2024
| @@ -230,8 +230,6 @@ def emulate(self, *coroutines: Iterable[Coroutine]): | |||
|
|
|||
| try: | |||
| self.run_with(*coroutines) | |||
There was a problem hiding this comment.
I suspect the original reasoning for this was to allow keyboard emulations to forward user-inputted ctrl+c to the target but I agree this would be better handled in user code.
| @@ -67,7 +67,8 @@ def filter_control_out(self, req, data): | |||
| # handle it ourself, and absorb it. | |||
| if req.get_recipient() == self.RECIPIENT_DEVICE and \ | |||
| req.request == self.SET_ADDRESS_REQUEST: | |||
| self.device.handle_set_address_request(req) | |||
| req.acknowledge(blocking=True) | |||
| self.device.set_address(req.value) | |||
| return None, None | |||
There was a problem hiding this comment.
Nice catch. Filters should also work with variants of USBDevice.
| @@ -210,7 +210,7 @@ def from_integer(cls, value): | |||
| """ Special factory that correctly handles reserved values. """ | |||
|
|
|||
| # If we have one of the reserved values; indicate so. | |||
| if 4 <= value < 16: | |||
| if 4 <= value < 32: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.