Set DYLD_FALLBACK_LIBRARY_PATH on macOS #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew patches it's own python so that ctypes.find_library can find libraries also installed by homebrew. When using a version of python not installed by Homebrew, this sets DYLD_FALLBACK_LIBRARY_PATH so that the homebrew-installed libraries are found.
|
Should this also check the existence of the the homebrew environment variable? |
|
I feel like it might be better to warn the user if the libusb dylib isn't found, and give them advice on fixing that, rather than just tweaking the search path internally in Otherwise you get a quite confusing situation where scripts using our libraries will work, but other software, or users' own scripts using |
|
@martinling that makes sense, I'll close this out in favor of what you are suggesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for greatscottgadgets/cynthion#136
Homebrew patches it's own python so that
ctypes.find_librarycan find libraries also installed by homebrew. When using a version of python not installed by Homebrew, this setsDYLD_FALLBACK_LIBRARY_PATHso that the homebrew-installedlibusblibrary is found.I tested this on my ARM Mac, but I don't have an Intel Mac to test this with. Can somebody with an Intel Mac try this out and see if it also works for them?