-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --version
option and About dialog
#125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but I get some warnings when I click the menu button:
(packetry:95267): Gtk-CRITICAL **: 15:54:33.990: _gtk_css_corner_value_get_x: assertion 'corner->class == >K_CSS_VALUE_CORNER' failed
(packetry:95267): Gtk-CRITICAL **: 15:54:33.990: _gtk_css_corner_value_get_y: assertion 'corner->class == >K_CSS_VALUE_CORNER' failed
I'm on:
I think this is a GTK bug fixed in: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6092 |
I'm on 4.12.5 and I don't see those messages. I think we can assume it's not our fault. |
I realized just too late that there is an issue with this when building outside a git repository:
This would happen if someone downloads a "source code" archive from a release on GitHub or (as some distro packagers are known to do) checks out a tag from the repo but omits the |
This PR adds a
--version
command line option, and an About dialog to the UI.Version information is captured at compile time with the git_version macro, so that it is possible to identify builds from non-release versions.
The About dialog includes basic package information, the BSD license text for Packetry itself, and some system information: OS, architecture and GTK library version in use.
It does not yet include copyright or license information for any dependencies.