-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Also convert dates for nextDate comparisons #3818
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3818 +/- ##
=======================================
Coverage 60.09% 60.09%
=======================================
Files 1023 1023
Lines 25153 25152 -1
Branches 7436 7434 -2
=======================================
+ Hits 15115 15116 +1
+ Misses 9096 9094 -2
Partials 942 942
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What
In Event.nextDate convert dates with the timezone before comparing to now. This is similar to converting the dates before returning them.
Why
The dates have floating timezones so they need to be converted, else they are treated as UTC when being converted to Unix time.
To reproduce:
faketime '2022-12-05 08:15:42' gsad...
faketime '2022-12-05 08:15:42' gvmd...
export TZ=America/New_York
faketime '2023-02-14 17:56' some_web_browser
To also confirm that task starts:
References
Closes /greenbone/gvmd/issues/1911.
GEA-114
Checklist