Remove scanner, type from configs, re-add hr_name for nvt preferences #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the field config_type was only used for OSP scanners the field and the corresponding code is removed from the gvmd sources. Further the field hr_name was rebuilt for NVT preferences.
Since the field "scanner" of the database table "configs" was only used in connection with OSP scanners and OSP scanners are no longer supported the corresponding code is removed from the gvmd-sources.
Added the documentation for the hr_name (human readable name) in the function header of function "preference_new (..)".
timopollmeier
changed the title
Since the field "type" of the database table "configs" was only used in connection with OSP scanners and OSP scanners are no longer supported the corresponding code is removed from the gvmd-sources.
jhelmold
changed the title
Since the fields type and scanner of the database table configs were only used in connection with OSP scanners and OSP scanners are no longer supported, the corresponding code has been removed from the gvmd-sources. This is the corresponding database adjustment, where, amongs others, the fields type and scanner are dropped from the table configs.
timopollmeier
requested changes
Oct 6, 2021
Minor changes to the source code regarding the removal of the fields scanner, type, config_type and hr_name.
Since in the function "create_task_check_config_scanner_type" the config type is no longer checked and only the scanner type is verified, the name of this function was changed to "create_task_check_scanner_type".
timopollmeier
approved these changes
Oct 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
OSP scanners are no longer supported. The field config_type and the fields scanner
and type from the database table configs where only used in connection with OSP
scanners. Accordingly the code corresponding to these fields has been removed from
the gvmd-sources. The corresponding data and the database fields scanner and type
of the table configs have been removed from the database. Besides the hr_name has
been rebuilt for nvt preferences.
Why:
OSP scanners are no longer supported.
Addresses AP-1562.
How did you test it:
Tested the Scan Configs and the Scanners dialog. Tested the according Trashcan
functionality. Tested the Tasks dialog and ran some scans.
Checklist: