Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check of uploaded certificate for TippingPoint SMS alerts. #2049

Conversation

jhelmold
Copy link
Member

What

Now the uploaded certificate for a TippingPoint SMS alert is checked, if it is a valid X509 certificate in PEM format. This check takes place before the alert data is saved.

Why

The missing check caused bugs.

References

GEA-254

Checklist

Tested manually on my local development system.

  • Tests

Now the uploaded certificate for a TippingPoint SMS alert is
checked, if it is a valid X509 certificate in PEM format.
This check takes place before the alert data is saved.
@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@jhelmold jhelmold marked this pull request as ready for review July 21, 2023 13:03
@jhelmold jhelmold requested review from a team and mattmundell as code owners July 21, 2023 13:03
@timopollmeier timopollmeier merged commit a86b543 into main Jul 21, 2023
9 checks passed
@timopollmeier timopollmeier deleted the GEA-254_Uploading_DER_file_as_TippingPoint_certificate_corrupts_alert branch July 21, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants