Added check of uploaded certificate for TippingPoint SMS alerts. #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the uploaded certificate for a TippingPoint SMS alert is checked, if it is a valid X509 certificate in PEM format. This check takes place before the alert data is saved.
Conventional Commits Report
🚀 Conventional commits found. |
…ertificate_corrupts_alert
timopollmeier
approved these changes
Jul 21, 2023
timopollmeier
deleted the
GEA-254_Uploading_DER_file_as_TippingPoint_certificate_corrupts_alert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Now the uploaded certificate for a TippingPoint SMS alert is checked, if it is a valid X509 certificate in PEM format. This check takes place before the alert data is saved.
Why
The missing check caused bugs.
References
GEA-254
Checklist
Tested manually on my local development system.