Avoid deadlocks while refreshing authentication #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
use a transaction and FOR UPDATE during selection to lock the row being updated to reduce likelihood of a deadlock.
a-h-abdelsalam
force-pushed
the
avoid-deadlocks-while-refreshing-authentication
branch
from
e493fa3
to
8c5eb25
Compare
jhelmold
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added FOR UPDATE in selection and a transaction to lock the row being updated during authentication refresh.
Added table prefix to the qod_type column of the result iterator.
Why
To reduce the likelihood of a deadlock while refreshing authentication.
Adding the table prefix to qod_type to address SQL errors while filtering results. This was also causing scans to go into interrupted state (See GEA-526)
References
GEA-505, GEA-526