Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deadlocks while refreshing authentication #2176

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

a-h-abdelsalam
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam commented Apr 23, 2024

What

Added FOR UPDATE in selection and a transaction to lock the row being updated during authentication refresh.
Added table prefix to the qod_type column of the result iterator.

Why

To reduce the likelihood of a deadlock while refreshing authentication.

Adding the table prefix to qod_type to address SQL errors while filtering results. This was also causing scans to go into interrupted state (See GEA-526)

References

GEA-505, GEA-526

@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner April 23, 2024 10:52
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

use a transaction and FOR UPDATE during selection to lock the row
being updated to reduce likelihood of a deadlock.
@a-h-abdelsalam a-h-abdelsalam force-pushed the avoid-deadlocks-while-refreshing-authentication branch from e493fa3 to 8c5eb25 Compare April 25, 2024 08:00
@jhelmold jhelmold merged commit 8913552 into main Apr 25, 2024
9 checks passed
@jhelmold jhelmold deleted the avoid-deadlocks-while-refreshing-authentication branch April 25, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants