Change: replace utf8_substring with g_utf8_substring #2204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the GET iterator initializers modify their get_data_t arg, so this allows these initializers to be passed to get_next. In particular this allows init_note_iterator_all to be passed to get_next, for a fix to handle_get_notes. Note that init_note_iterator_all itself does not modify its get_data_t arg, but init_note_iterator_all is passed to select_resource_iterator which also accepts initializers that do modify their get_data_t args. As a result drop the const from any initializer passed to get_next.
Conventional Commits Report
🚀 Conventional commits found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use the real
g_utf8_substringfrom glib, instead of the copyutf8_substring.Why
utf8_substringwas a workaround for older versions of glib. As the required version of glib is now2.42it is safe to useg_utf8_substring.Simple test: create a note with utf8 text:
Then get the notes with excerpts on:
References
Waits for /pull/2203.