Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stray details checks from GET_ASSETS #2254

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Remove stray details checks from GET_ASSETS #2254

merged 1 commit into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. Remove stray details checks from GET_ASSETS 

    The details attribute is store in get_assets_data->get.details. These
checks on get_assets_data->details are probably copy-paste errors from
GET_INFO. This works in GET_INFO because GET_INFO explicitly sets
details alongside get.details.

As a result the DETAILS element has never been returned from
GET_ASSETS. It's also missing from the docs.

Similarly, ROUTES is only returned from GET_ASSETS when an id
attribute is given, regardless of the value of the details attribute.
    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1b09ee5 View commit details
    Browse the repository at this point in the history