Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CMake script. Improve C++ language feature selection #243

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Correct CMake script. Improve C++ language feature selection #243

merged 6 commits into from
Jun 25, 2024

Conversation

scivision
Copy link
Contributor

  • CMake already required CMake >= 3.13, it would error immediately without that
  • Use canonical way to set per-language compiler options
  • Use simpler, modern CI configuration
  • use C++ [[fallthrough]] that most compilers have
  • use C++ [[noreturn]] that most compilers have

@greg7mdp greg7mdp merged commit e5b892b into greg7mdp:master Jun 25, 2024
10 checks passed
@greg7mdp
Copy link
Owner

Thanks a lot for the great PR @scivision

@chenrui333 chenrui333 mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scivision @greg7mdp