Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing outdated WebSocket with ws4py #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remram44
Copy link

This feels hacky (but works).

Instead of reimplementing the RFC, I used ws4py's implementation.

This needs extensive testing. I'm also not content with the dup() call, there must be a way to prevent Django from fiddling with the socket...

@gregmuellegger
Copy link
Owner

This looks really good! Thanks for your efforts! I hope to find time to integrate these changes -- but before I can merge them, they need some tests. The current test suite won't run.

@zmasek
Copy link

zmasek commented Aug 14, 2013

Is there any chance this will get integrated? I've been playing for a while with that code. I can't say if it's successful since I don't know that much about sockets yet. I've been using Arduino to get data into the Raspberry PI where I'm having a stack made from nginx, circus, chaussette, ws4py, gevent, zmq and django. Right now it sends data to the client, but I didn't try to send data from the browser back to the server yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants