Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with GHC 8.4.1-alpha1 #45

Closed
asr opened this issue Dec 21, 2017 · 5 comments
Closed

Build error with GHC 8.4.1-alpha1 #45

asr opened this issue Dec 21, 2017 · 5 comments

Comments

@asr
Copy link
Contributor

asr commented Dec 21, 2017

GHC 8.4.1-alpha1 was announced. While testing Agda with this version of GHC, I got the following error on hashtables (master branch):

$ cabal install
...
src/Data/HashTable/ST/Basic.hs:491:10: error:
    • No instance for (Semigroup Slot)
        arising from the superclasses of an instance declaration
    • In the instance declaration for ‘Monoid Slot’
    |
491 | instance Monoid Slot where
    |          ^^^^^^^^^^^
Failed to install hashtables-1.2.2.1

Blocking agda/agda#2878.

@asr
Copy link
Contributor Author

asr commented Dec 22, 2017

Note that this error is reported as a warning in GHC 8.0.2/8.2.2 using the -Wsemigroup flag:

$ cabal install --force-reinstalls --ghc-options='-Wsemigroup -Werror'

So, fixing this warning on GHC 8.0.2/8.2.2 fix the error on GHC 8.4.1-alpha1.

@asr
Copy link
Contributor Author

asr commented Dec 25, 2017

For knowing the warnings in GHC 8.0.2/8.2.2, I realised it's better to use the -Wcompat flag:

$ cabal install --force-reinstalls --ghc-options='-Wcompat -Werror'

@DanBurton
Copy link

Bump. ghc-8.4.1 is out now; same issue.

@simonmichael
Copy link

Two PRs have been pending for a while: #46, #47. @gregorycollins, any chance you could merge and ship a quick release ?

@mgmeier
Copy link
Collaborator

mgmeier commented May 22, 2018

hashtables conforms to the SMP as of release 1.2.3.0, closing this issue now.

@mgmeier mgmeier closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants