Day16: Functional tests #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregurco
reviewed
Jul 2, 2019
| @@ -0,0 +1,30 @@ | |||
| # This file is a "template" of which env vars need to be defined for your application | |||
There was a problem hiding this comment.
What do you think about keeping in .env.test only the diff drom .env? So, if MAILER_URL is different, then we add it to this file. In case of APP_SECRET, I think it can be removed from this file and so on.
| @@ -21,4 +21,5 @@ | |||
| FOS\RestBundle\FOSRestBundle::class => ['all' => true], | |||
| JMS\SerializerBundle\JMSSerializerBundle::class => ['all' => true], | |||
| Symfony\WebpackEncoreBundle\WebpackEncoreBundle::class => ['all' => true], | |||
| Liip\FunctionalTestBundle\LiipFunctionalTestBundle::class => ['dev' => true, 'test' => true], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the most obvious tests (not all the negative or border edge cases). Aiming to cover controllers and repositories, as those are hard to cover with proper unit tests.