Merge pull request #162 from grendel-consulting/bugfixes

fix: reflect bugfixes in Kolide API
grendel-consulting · Jun 26, 2024 · 7c1459d · 7c1459d
2 parents fdf7538 + c7622b4
commit 7c1459d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/kolide/client/devices.go b/kolide/client/devices.go
@@ -28,8 +28,7 @@ type Device struct {
 }
 
 type RegisteredOwner struct {
-	// Whilst the Kolide API readme entry references this as a "string", the returned value encountered during implementation is an "int"
-	Identifier int32 `json:"identifier,omitempty"`
+	Identifier string `json:"identifier,omitempty"`
 }
 
 type AuthConfiguration struct {

diff --git a/kolide/client/issues.go b/kolide/client/issues.go
@@ -25,13 +25,11 @@ type Issue struct {
 }
 
 type DeviceInformation struct {
-	// Whilst the Kolide API readme entry references this as a "string", the returned value encountered during implementation is an "int"
-	Identifier int32 `json:"identifier,omitempty"`
+	Identifier string `json:"identifier,omitempty"`
 }
 
 type CheckInformation struct {
-	// Whilst the Kolide API readme entry references this as a "string", the returned value encountered during implementation is an "int"
-	Identifier int32 `json:"identifier,omitempty"`
+	Identifier string `json:"identifier,omitempty"`
 }
 
 func (c *Client) GetIssues(cursor string, limit int32, searches ...Search) (interface{}, error) {

diff --git a/kolide/client/registration_requests.go b/kolide/client/registration_requests.go
@@ -18,8 +18,7 @@ type RegistrationRequest struct {
 }
 
 type RequesterInformation struct {
-	// Whilst the Kolide API readme entry references this as a "string", the returned value encountered during implementation MAY BE an "int"
-	Identifier int32 `json:"identifier,omitempty"`
+	Identifier string `json:"identifier,omitempty"`
 }
 
 func (c *Client) GetRegistrationRequests(cursor string, limit int32, searches ...Search) (interface{}, error) {