-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement worked example of search #49
Conversation
Warning Rate Limit Exceeded@ramirezj has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 47 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update enhances the search functionality in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (4)
- kolide/client/client.go (3 hunks)
- kolide/client/devices.go (1 hunks)
- kolide/table_kolide_k2_device.go (4 hunks)
- kolide/utils.go (2 hunks)
Additional comments: 6
kolide/client/client.go (1)
- 16-29: The introduction of
OperatorType
andSearch
types, along with related constants, is well-implemented and aligns with the PR objectives. These changes effectively support the serialization of search criteria.kolide/client/devices.go (2)
- 14-22: The updates to the JSON tags in the
Device
struct, including the use ofomitempty
, are appropriate and align with the PR objectives to optimize the serialization process.- 28-31: The enhancements to the
GetDevices
method, including accepting variadicSearch
parameters and the integration withserializeSearches
, significantly improve the flexibility and power of search queries.kolide/table_kolide_k2_device.go (3)
- 16-44: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [19-65]
The modifications and additions to the table definition, including new columns and adjustments to
KeyColumns
for filtering, effectively enhance the representation of device data and support the new search functionality.
- 78-101: The refactoring of the
listDevices
function to handle searches based on qualifiers is well-implemented, leveraging the new search capabilities effectively.- 101-101: The
getDevice
function remains effective in retrieving a device by ID, and its integration with theconnect
function is correctly implemented.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- kolide/client/client.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- kolide/client/client.go
closes #16
Summary by CodeRabbit
kolide_client
package, allowing for more refined queries based on new search criteria.