Reload redis scripts on reconnect #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gresrun
requested changes
Aug 26, 2018
| final String curQueue) { | ||
| if (exception instanceof JedisConnectionException | ||
| || exception instanceof JedisNoScriptException | ||
| || (exception instanceof JedisDataException && exception.getMessage().equals("LOADING Redis is loading the dataset in memory"))) { |
There was a problem hiding this comment.
done (i actually moved it to a separate variable, as breaking inside the if was making it even more unreadable)
| @@ -557,7 +556,16 @@ protected void recoverFromException(final String curQueue, final Exception ex) { | |||
| final RecoveryStrategy recoveryStrategy = this.exceptionHandlerRef.get().onException(this, ex, curQueue); | |||
| switch (recoveryStrategy) { | |||
| case RECONNECT: | |||
| LOG.info("Ignoring RECONNECT strategy in response to exception because this is a pool", ex); | |||
| if (ex instanceof JedisNoScriptException) { | |||
| LOG.info("got JedisNoScriptException while reconnecting, reloading redis scripts"); | |||
There was a problem hiding this comment.
Nit: Capital 'G' for start of sentence. Also, Redis should be capitalized.
| LOG.info("got JedisNoScriptException while reconnecting, reloading redis scripts"); | ||
| loadRedisScripts(); | ||
| } else { | ||
| LOG.info("waiting for pool to reconnect to redis", ex); |
There was a problem hiding this comment.
Same. Also, consider adding the duration of the wait to the message.
bp-FLN
force-pushed
the
reload-scripts-on-reconnect
branch
from
c3927ea
to
b510425
Compare
|
@gresrun any idea when this fix will be available in maven. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is basically the same as #143, but for
WorkerPoolImpl