Supporting non default namespace when NextQueueStrategy is RESET_TO_HIGHEST_PRIORITY #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofirnk
reviewed
Oct 1, 2018
| @@ -15,7 +16,7 @@ local OPTIONAL_SPACE_SEPARATOR = '%s*' | |||
| local NEXT_QUEUE_REGEX = QUEUE_NAME_CAPTURING_REGEX .. OPTIONAL_COMMA_SEPARATOR .. OPTIONAL_SPACE_SEPARATOR | |||
|
|
|||
| for q in queues.gmatch(queues, NEXT_QUEUE_REGEX) do | |||
| local queueName = 'resque:queue:' .. q | |||
There was a problem hiding this comment.
Default namespace is resque?
Just make sure this change is backwards compatible
There was a problem hiding this comment.
just checked it:
so default namespace seems to be resque
There was a problem hiding this comment.
@ofirnk Yes, tested by enqueuing using the old client and reading using the new client. And yes, resque was the default namespace being used.
ofirnk
approved these changes
Oct 1, 2018
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing namespace in the lua script that supports priority queues