Fixes for queues being appended to the worker name and IDLE state workers. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2013 19:49
The worker name was set before the queues so they were not available at the time of setting the name.
Workers without a payload and are not paused should not be returned when looking for WORKING workers.
|
Thanks for the quality pull request! |
gresrun
added a commit
that referenced
this pull request
Nov 15, 2013
Fixes for queues being appended to the worker name and IDLE state workers.
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of potential fixes for setting the worker name and getting the worker state.
The name of the worker was never appending the queue names to the end of the worker name because the name was set before queues had been populated in the WorkerImpl constructor.
Jesque-Web was showing IDLE workers as WORKING in the Overview page. This applies a fix so that workers with no payload do not show up when asking for WORKING workers.