1661 bug fix raw diff viewer #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretchenfrage
force-pushed
the
1661-bug-fix
branch
6 times, most recently
from
bfc9b75
to
89f208d
Compare
gretchenfrage
force-pushed
the
1661-bug-fix
branch
6 times, most recently
from
d0e8175
to
ce62a7a
Compare
In preparation for allowing IP server names (with rustls 0.23).
Co-authored-by: gabrik <[email protected]>
Signed-off-by: gabrik <[email protected]>
gretchenfrage
force-pushed
the
1661-bug-fix
branch
3 times, most recently
from
3dcc72a
to
eb372bb
Compare
Retry source CIDs are under our control and are already required to be unpredictable, so they make a fine basis for key derivation.
Allows multiple tasks to concurrently wait for writability on the same socket. See the [tokio] and [async-io] docs for details. [tokio]: https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html [async-io]: https://docs.rs/async-io/latest/async_io/struct.Async.html#concurrent-io
Dropping these has low cost because they're not associated with any connection.
`UdpState` was removed some time ago, and various other interface details have changed. As a result, the build would fail on platforms without native support.
As we no longer buffer multiple transmits in memory, this complexity is unused. GSO is expected to account for most, if not all, of the performance benefit.
Because we no longer buffer transmits for unpredictable periods, there's no need to share ownership of their contents.
This didn't impact any tests, but was confusing.
We no longer need to share ownership of this memory, so we should use a simpler type to reflect our simpler requirements.
gretchenfrage
force-pushed
the
1661-bug-fix
branch
2 times, most recently
from
c63dc5d
to
03294a8
Compare
gretchenfrage
force-pushed
the
1661-bug-fix
branch
2 times, most recently
from
fc23130
to
eba944e
Compare
Closes quinn-rs#1820 The fix: - Endpoint now maintains a slab with an entry for each pending Incoming to buffer received data. - ConnectionIndex now maps initial DCID to that slab key immediately upon construction of Incoming. - If Incoming is accepted, association is overridden with association with ConnectionHandle, and all buffered datagrams are fed to newly constructed Connection. - If Incoming is refused/retried/ignored, or accepting errors, association and slab entry are cleaned up to prevent memory leak. Additional considerations: - The Incoming::ignore operation can no longer be implemented as just dropping it. To help prevent incorrect API usage, proto::Incoming is modified to log a warning if it is dropped without being passed to Endpoint::accept/refuse/retry/ignore. - Three things protect against memory exhaustion attacks here: 1. The MAX_INCOMING_CONNECTIONS limit is moved from quinn to proto, limiting the number of concurrent incoming connections for which datagrams will be buffered before the application decides what to do with them. Also, it is changed from a constant to a field of the server config, max_incoming. 2. Per-incoming buffered data is limited to a new limit stored in the server config, incoming_buffer_size, beyond which subsequent packets are discarded if received in these conditions. 3. The sum total of all incoming buffered data is limited to a new limit stored in the server config, incoming_buffer_size_total, beyond which subsequent packets are discarded if received in these conditions.
gretchenfrage
force-pushed
the
1661-bug-fix
branch
from
eba944e
to
b76f7a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.