Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FE assemble for multiple terms #42

Closed
fverdugo opened this issue Jul 4, 2019 · 2 comments
Closed

Extend FE assemble for multiple terms #42

fverdugo opened this issue Jul 4, 2019 · 2 comments

Comments

@fverdugo
Copy link
Member

fverdugo commented Jul 4, 2019

Needed to solve problems with weak forms that include terms that are integrated over different domains.

This is a subtask needed in issue #29

Work being done in branch extend_assembler_to_multiple_fields

@fverdugo
Copy link
Member Author

fverdugo commented Jul 4, 2019

Changes needed:

  • Add a new argument ::CellNumber{<:Integer} to apply_constraints, apply_constraints_rows, and apply_constraints_cols in the interfaces FESpace and MultiFESpace. Apply these changes to all concrete implementations.
  • Change the signature of assembleto account for several terms. The user call should be like this one: f = assemble(asem,(cv1,cn1),(cv2,cn2),(cv3,cn3)). We also want to keep the current API f=assemble(assem,cv1) as a particular case. It can be implemented in the abstract type using the new more general abstract method.
  • Previous step would require to implement a new IdentityCellNumber

fverdugo added a commit that referenced this issue Jul 5, 2019
This PR extends the FE assembly routines to support weak forms with several terms, which are integrated in different domains. E.g., problems with Neumann BCs.

This PR addresses issue #42
@fverdugo
Copy link
Member Author

fverdugo commented Jul 5, 2019

Fixed by PR #43

Closing issue.

@fverdugo fverdugo closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant