Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fill_entries! and use LinearAlgebra.fillstored! #678

Closed
fverdugo opened this issue Oct 19, 2021 · 6 comments
Closed

remove fill_entries! and use LinearAlgebra.fillstored! #678

fverdugo opened this issue Oct 19, 2021 · 6 comments
Assignees
Labels
breaking enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@fverdugo
Copy link
Member

fverdugo commented Oct 19, 2021

Now it is a good time to do this before releasing 0.17.

cc @amartinhuertas

@fverdugo fverdugo added enhancement New feature or request breaking labels Oct 19, 2021
@fverdugo fverdugo added this to the v0.17 milestone Oct 19, 2021
@fverdugo
Copy link
Member Author

fverdugo commented Oct 19, 2021

The only non-obvious part is that the implementation of fill_entries! for SparseMatrixCSR needs to be done in its own package (https://github.com/gridap/SparseMatricesCSR.jl) to avoid type piracy.

@fverdugo fverdugo added the help wanted Extra attention is needed label Oct 19, 2021
@fverdugo
Copy link
Member Author

To think also if we can find Julia equivalents of functions like scale_entries! (i.e. scaling the stored values)

@amartinhuertas
Copy link
Member

I will do this

@amartinhuertas amartinhuertas self-assigned this Oct 19, 2021
@fverdugo
Copy link
Member Author

For scale_entries! we can use rmul! instead:

help?> rmul!
search: rmul! baremodule parentmodule promote_rule

  rmul!(A::AbstractArray, b::Number)

  Scale an array A by a scalar b overwriting A in-place. Use lmul! to multiply scalar from left. The scaling operation respects the semantics of the multiplication * between an element of
  A and b. In particular, this also applies to multiplication involving non-finite numbers such as NaN and ±Inf.

@amartinhuertas
Copy link
Member

See PR #680 for the status of this work

@fverdugo
Copy link
Member Author

Closed via PR #680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants