Replacing fill_stored! by fill! or LinearAlgebra.fillstored! for arrays #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and sparse matrices, resp.
Codecov Report
@@ Coverage Diff @@
## release_0.17 #680 +/- ##
================================================
- Coverage 87.91% 87.91% -0.01%
================================================
Files 131 131
Lines 14680 14669 -11
================================================
- Hits 12906 12896 -10
+ Misses 1774 1773 -1
Continue to review full report at Codecov.
|
@fverdugo ... this PR is ready to review. |
fverdugo
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
The code looks good! Now waiting for tests.
(I have removed the Manifest and added [email protected])
JordiManyer
deleted the
replace_fill_entries_scale_entries_by_stlib_functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP ... not yet ready to be merged.