Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugfix in 1d CartesianGrid #192

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Small bugfix in 1d CartesianGrid #192

merged 1 commit into from
Feb 25, 2020

Conversation

fverdugo
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #192 into master will increase coverage by 6.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   82.64%   88.91%   +6.26%     
==========================================
  Files         133      133              
  Lines        6622     8193    +1571     
==========================================
+ Hits         5473     7285    +1812     
+ Misses       1149      908     -241
Impacted Files Coverage Δ
src/Geometry/CartesianGrids.jl 88% <66.66%> (+18.35%) ⬆️
src/FESpaces/FESpaceFactories.jl 85.71% <0%> (-10.07%) ⬇️
src/Geometry/GridTopologyMocks.jl 90.47% <0%> (-9.53%) ⬇️
src/Geometry/UnstructuredGrids.jl 68.42% <0%> (-4.92%) ⬇️
src/Algebra/NLSolvers.jl 98.66% <0%> (-1.34%) ⬇️
src/Gridap.jl 100% <0%> (ø) ⬆️
src/Exports.jl 100% <0%> (ø) ⬆️
src/MultiField/MultiField.jl 100% <0%> (ø) ⬆️
src/FESpaces/FESpaces.jl 100% <0%> (ø) ⬆️
src/Polynomials/QGradMonomialBases.jl 100% <0%> (ø) ⬆️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85fc8d...86b81a3. Read the comment docs.

@fverdugo fverdugo merged commit b86c26e into master Feb 25, 2020
@fverdugo fverdugo deleted the fix_1d_cartesian_grid branch February 25, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants