Periodic BC for cartesian grids #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added field isperiodic to cartesian descriptor * Modified constructors of CartesianDescriptor and CartesianDiscreteModel * Added new method for _generate_cell_to_vertices_from_grid in UnstructuredGrids.jl that implements the grid numbering for periodic BC. * Added test PeriodicBC.jl in Geometry tests to check proper numbering of vefs with periodic BC. * Added tests PeriodicDarcy.jl and PeriodicCoupledPoisson.jl to check both with periodic BC.
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 88.94% 89.00% +0.05%
==========================================
Files 147 147
Lines 9604 9646 +42
==========================================
+ Hits 8542 8585 +43
+ Misses 1062 1061 -1
Continue to review full report at Codecov.
|
added 2 commits
May 26, 2020 10:19
* Converted optional arguments of CartesianDescriptor constructors to key-word arguments. * Added deprecated signatures for backwards compatibility. * Uptated tests to use new signatures. * Updated News.md.
fverdugo
requested changes
May 26, 2020
* Minor changes in CartesianDescriptor documentation * Renamed UnstructuredGridTopology used for numbering a grid with periodic BC to _cartesian_grid_topology_with_periodic_bcs. * Moved above function (and related) to CartesianGrids.jl
fverdugo
approved these changes
May 27, 2020
|
PR merged! Now, you appear in the list of Gridap contributors. Welcome! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnstructuredGrids.jl that implements the grid numbering for periodic BC.
with periodic BC.
with periodic BC.
Minor changes are still required in
CartesianDescriptorconstructors (see issue #263). Apart from that, I would say it is ready to merge.