Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cross product operation for vectors #280

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

jesusbonilla
Copy link
Collaborator

  • Implemented the cross product for R2 and R3 VectorValue gridap types
  • Added tests to assess its implementation

* Implemented the cross product for R2 and R3 VectorValue gridap types
* Added tests to assess its implementation
@jesusbonilla jesusbonilla self-assigned this Jun 12, 2020
* Added tests for cross() function
* Updated NEWS.md
@fverdugo fverdugo self-requested a review June 12, 2020 11:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #280 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   88.27%   88.26%   -0.01%     
==========================================
  Files         153      153              
  Lines        9960     9963       +3     
==========================================
+ Hits         8792     8794       +2     
- Misses       1168     1169       +1     
Impacted Files Coverage Δ
src/TensorValues/Operations.jl 86.28% <66.66%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cab0d...cfbb71d. Read the comment docs.

@fverdugo fverdugo merged commit 8b5905d into master Jun 12, 2020
@fverdugo fverdugo deleted the add_cross_product_for_VectorValues branch June 12, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants