Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix master by restricting WriteVTK version #287

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

fverdugo
Copy link
Member

No description provided.

@fverdugo fverdugo merged commit 623c45d into master Jun 22, 2020
@fverdugo fverdugo deleted the fix_master branch June 22, 2020 07:19
@PetrKryslUCSD
Copy link

So are you saying that VTK 1.7 is (was) broken?

@amartinhuertas
Copy link
Member

Hi @PetrKryslUCSD!

the package update ↑ WriteVTK v1.6.0 ⇒ v1.7.1 breaks some ot the tests in our project.

See the following issue for further details: #286

We did not dig deep yet into the cause of the broken test, but accordingly to the error backtrace reported in #286, we suspect that the changes in v.1.7.0 introduced in MeshCell may well behind the broken test (see the following comment: #286 (comment) for more details).

Are u experiencing issues with VTK 1.7 as well?

@amartinhuertas
Copy link
Member

I think I could fix the broken tests in our particular case (comprehensive test suite still underway).

See ccd7565 for more details.

@PetrKryslUCSD
Copy link

No, I am on
[64499a7a] WriteVTK v1.7.1
and I have seen no errors.

@jipolanco
Copy link

Hi, I just noticed this issue. I apologise for the breaking changes in WriteVTK, and I'm glad to see that you figured out the solution in #324.

To clarify, the MeshCell type in WriteVTK was modified in v1.7 to support the definition of polygonal meshes, which are a specific type of unstructured mesh. As I mentioned in a related issue, I didn't expect this change to break other projects such as this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants