Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DiracDelta #485

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Added DiracDelta #485

merged 1 commit into from
Nov 27, 2020

Conversation

fverdugo
Copy link
Member

Fixes issue #408

Fixes issue #408
@fverdugo fverdugo mentioned this pull request Nov 27, 2020
@stevengj
Copy link
Contributor

How do you specify the amplitude? Can you do e.g. 3 * DiracDelta(...) or f * DiracDelta (where f(x) is a function of position)?

@stevengj
Copy link
Contributor

What do you do if you have piecewise-constant test functions, since then you have a discontinuity right where the delta function is? I guess you could use the average of the two sides…

@codecov-io
Copy link

Codecov Report

Merging #485 (5a85738) into master (3b7fc18) will increase coverage by 0.11%.
The diff coverage is 85.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   85.69%   85.80%   +0.11%     
==========================================
  Files         143      144       +1     
  Lines       10884    10907      +23     
==========================================
+ Hits         9327     9359      +32     
+ Misses       1557     1548       -9     
Impacted Files Coverage Δ
src/CellData/CellData.jl 100.00% <ø> (ø)
src/Exports.jl 5.88% <ø> (ø)
src/CellData/DiracDeltas.jl 81.48% <81.48%> (ø)
src/Geometry/BoundaryTriangulations.jl 94.50% <100.00%> (ø)
src/TensorValues/Operations.jl 89.43% <100.00%> (+2.37%) ⬆️
src/Geometry/FaceLabelings.jl 77.39% <0.00%> (+1.20%) ⬆️
src/TensorValues/TensorValueTypes.jl 78.57% <0.00%> (+1.42%) ⬆️
src/Integration/TensorProductQuadratures.jl 95.34% <0.00%> (+8.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7fc18...5a85738. Read the comment docs.

@fverdugo fverdugo merged commit 3cf65bd into master Nov 27, 2020
@fverdugo fverdugo deleted the diracs_deltas branch November 27, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants