Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide rand function for TensorValues #530

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

eschnett
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #530 (90b21de) into master (5d7252b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   86.14%   86.18%   +0.03%     
==========================================
  Files         145      145              
  Lines       11327    11348      +21     
==========================================
+ Hits         9758     9780      +22     
+ Misses       1569     1568       -1     
Impacted Files Coverage Δ
src/TensorValues/TensorValues.jl 100.00% <ø> (ø)
src/TensorValues/SymFourthOrderTensorValueTypes.jl 77.35% <100.00%> (+2.35%) ⬆️
src/TensorValues/SymTensorValueTypes.jl 66.66% <100.00%> (+2.28%) ⬆️
src/TensorValues/TensorValueTypes.jl 80.00% <100.00%> (+1.42%) ⬆️
src/TensorValues/ThirdOrderTensorValueTypes.jl 54.38% <100.00%> (+6.30%) ⬆️
src/TensorValues/VectorValueTypes.jl 80.43% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7252b...90b21de. Read the comment docs.

Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eschnett. This is very usefull. Thanks!

Can you add a small comment about the new functionality in NEWS.md ? In the "Unreleased" section, "Added" sub-section. E.g.:

# Changelog
All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

## Undeleased

### Added
- `rand` function for `MultiValue` objects.

@eschnett
Copy link
Contributor Author

eschnett commented Feb 2, 2021

Done.

@fverdugo fverdugo merged commit cd5048d into gridap:master Feb 2, 2021
@eschnett eschnett deleted the eschnett/random branch February 3, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants