Geometry #662
Merged
Geometry #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the FESpacesTests folder.
Also cosmetic changes in PoissonLagrangeMultiplierTests
|
Some remaining tasks associated with this PR are detailed in #660 |
Codecov Report
@@ Coverage Diff @@
## release_0.17 #662 +/- ##
================================================
- Coverage 87.73% 83.81% -3.93%
================================================
Files 134 136 +2
Lines 14369 14960 +591
================================================
- Hits 12607 12538 -69
- Misses 1762 2422 +660
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring on how data is transferred between different triangulations.
Changed
The
Triangulationinterface has changed. Now aTriangulationobject is understood as computational domain defined from aDiscreteModel. I.e., from the same FE mesh (the discrete model), we can extract different domains (several triangulations) like the boundary, the interior, or some portion of the interior or the boundary. These can be potentially used both for intergration (like before) but also for interpolation (except for unfitted triangulations). In consequence, types likeBoundaryDiscreteModelorExtendedDiscreteModelare no longer needed.