Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in LinearSolvers.jl #692

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Oct 25, 2021

Hi @fverdugo @amartinhuertas,

I found a typo in LinearSolvers.jl when trying to update GridapODEs. Apparently the function solve! in line

function solve!(x::AbstractVector,
was not stressed by any Gridap test. I added the corresponding test in LinearSolversTests.jl

@oriolcg oriolcg added the bug Something isn't working label Oct 25, 2021
@oriolcg oriolcg self-assigned this Oct 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #692 (1faacc4) into master (2015bd1) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   87.94%   88.06%   +0.12%     
==========================================
  Files         133      133              
  Lines       14968    14970       +2     
==========================================
+ Hits        13163    13184      +21     
+ Misses       1805     1786      -19     
Impacted Files Coverage Δ
src/Algebra/LinearSolvers.jl 92.98% <100.00%> (+17.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2015bd1...1faacc4. Read the comment docs.

@santiagobadia santiagobadia merged commit 390380a into master Oct 25, 2021
@fverdugo fverdugo deleted the fix_typo_LinearSolvers branch October 27, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants