Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing pvtk grid #699

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Removing pvtk grid #699

merged 2 commits into from
Oct 27, 2021

Conversation

amartinhuertas
Copy link
Member

No description provided.

fverdugo
fverdugo approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@fverdugo fverdugo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a breaking change, but it is so minor and in a very new and experimental funcion. So we can continue in the 0.17 release.

@fverdugo fverdugo merged commit d254860 into master Oct 27, 2021
@fverdugo fverdugo deleted the removing_pvtk_grid branch October 27, 2021 12:00
@amartinhuertas
Copy link
Member Author

This introduces a breaking change, but it is so minor and in a very new and experimental funcion. So we can continue in the 0.17 release.

Ok, agreed. We indeed know that it is only being used from GridapDistributed.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fverdugo fverdugo fverdugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amartinhuertas @fverdugo