Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test_broken in GridapDistributed #715

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

amartinhuertas
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #715 (2c7d73b) into master (dbb44a0) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   88.00%   88.12%   +0.12%     
==========================================
  Files         132      132              
  Lines       14970    15240     +270     
==========================================
+ Hits        13175    13431     +256     
- Misses       1795     1809      +14     
Impacted Files Coverage Δ
src/Arrays/SubVectors.jl 100.00% <100.00%> (ø)
src/Geometry/UnstructuredGrids.jl 100.00% <0.00%> (ø)
src/Fields/ArrayBlocks.jl 79.00% <0.00%> (+0.11%) ⬆️
src/Arrays/CompressedArrays.jl 90.90% <0.00%> (+0.21%) ⬆️
src/Geometry/CartesianDiscreteModels.jl 100.00% <0.00%> (+0.46%) ⬆️
src/Arrays/LazyArrays.jl 77.44% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb44a0...2c7d73b. Read the comment docs.

@fverdugo
Copy link
Member

Reproducer:

module TMP

using Gridap
inds = Int32[1,4,3]
a = rand(10)
sa = Gridap.Arrays.SubVector(a,1,5)
vsa = view(sa,inds)

b = rand(10)
vb = view(b,inds)

x = Base.broadcasted(+,vb,vsa)
Base.materialize!(vb,x)

end # module

@fverdugo fverdugo merged commit 6082973 into master Nov 22, 2021
@fverdugo fverdugo deleted the fix_test_broken_in_gridapdistributed branch November 22, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants