Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement addition and subtraction between TensorValue and SymTensorValue #755

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

ericneiva
Copy link
Member

Implements missing addition and subtraction between TensorValue and SymTensorValue types (+ tests).

@ericneiva ericneiva requested a review from fverdugo March 3, 2022 12:37
@ericneiva ericneiva self-assigned this Mar 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #755 (94b6cb8) into master (69cfe62) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   88.32%   88.35%   +0.02%     
==========================================
  Files         152      152              
  Lines       16595    16595              
==========================================
+ Hits        14658    14662       +4     
+ Misses       1937     1933       -4     
Impacted Files Coverage Δ
src/TensorValues/Operations.jl 90.23% <100.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cfe62...94b6cb8. Read the comment docs.

@fverdugo fverdugo merged commit 7046347 into master Mar 3, 2022
@fverdugo fverdugo deleted the implement_add-sub_tensorvalue_symtensorvalue branch March 3, 2022 13:52
@amartinhuertas
Copy link
Member

Hi @ericneiva ! Do you plan to use symmetric tensors in gridap ? I have explored their usage in gridaphybrid and detected several bugs that I have fixed there temporarily but I might expedite fixing them in gridap if you are going to need them.

@ericneiva
Copy link
Member Author

Hi, @amartinhuertas!

Yes, I am already using them on a driver which solves the linear elasticity problem on a 2-manifold. It requires subtracting symmetric and non-symmetric tensors. After this PR, I can integrate the weak form and everything appears to work.

I just have one question: Do any of these bugs provoke that your hybrid methods do not converge at the expected rate? If not, I'd say I do not depend on your fixes in the short-medium term.

Thanks a lot for your message 🙂

@amartinhuertas
Copy link
Member

There are a number of bugs. E.g. interpolation of analytical function inside Fe space

Here are the fixes fyi

https://github.com/gridap/GridapHybrid.jl/blob/main/src/tmp_fixes_symmetric_valued_lagrangian_reffes.jl

@ericneiva
Copy link
Member Author

It appears those fixes do not affect my results... for now.

I'll take a closer look later to double-check.

Thanks again, @amartinhuertas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants