Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming GridapODEs to ODEs #756

Merged
merged 8 commits into from
Mar 5, 2022
Merged

Renaming GridapODEs to ODEs #756

merged 8 commits into from
Mar 5, 2022

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Mar 3, 2022

The name of GridapODEs module is redundant, changing it to ODEs.

@oriolcg oriolcg self-assigned this Mar 3, 2022
@fverdugo
Copy link
Member

fverdugo commented Mar 4, 2022

If you really want to be consistent with semantic versioning, you can also temporarily add const GridapODEs = ODEs rigth after closing the ODEs module so that old code using Gridap.GridapODEs still works (this will prevent to start gridap 0.18 just for this small fix). Of course this should be removed in the next minor release.

@fverdugo fverdugo self-requested a review March 4, 2022 06:42
Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this renaming very convenient @oriolcg.

Perhaps you want to take into account my previous comment about semantic versioning. But this is not very crucial at this moment since perhaps you are the only one already using the odes part from Gridap directly.

@fverdugo
Copy link
Member

fverdugo commented Mar 4, 2022

BTW, this PR seems to have changes from PR #751. I would merge #751 before this one.

@oriolcg
Copy link
Member Author

oriolcg commented Mar 4, 2022

Done in 0a4ffb5. I accidentally pushed a version with PR #751 locally merged. It would be good to first accept PR #751 and then accept this PR.

@fverdugo
Copy link
Member

fverdugo commented Mar 4, 2022

Done in 0a4ffb5. I accidentally pushed a version with PR #751 locally merged. It would be good to first accept PR #751 and then accept this PR.

We wrote at the same time !

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #756 (b93eaaf) into master (7af5578) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files         152      152           
  Lines       16595    16595           
=======================================
  Hits        14662    14662           
  Misses       1933     1933           
Impacted Files Coverage Δ
src/Exports.jl 0.00% <ø> (ø)
src/ODEs/DiffEqsWrappers/DiffEqsWrappers.jl 0.00% <ø> (ø)
src/ODEs/ODETools/AffineNewmark.jl 100.00% <ø> (ø)
src/ODEs/ODETools/AffineThetaMethod.jl 83.52% <ø> (ø)
src/ODEs/ODETools/ConstantMatrixNewmark.jl 87.50% <ø> (ø)
src/ODEs/ODETools/ConstantNewmark.jl 96.20% <ø> (ø)
src/ODEs/ODETools/DiffOperators.jl 100.00% <ø> (ø)
src/ODEs/ODETools/ForwardEuler.jl 87.87% <ø> (ø)
src/ODEs/ODETools/Newmark.jl 91.66% <ø> (ø)
src/ODEs/ODETools/ODEOperators.jl 40.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af5578...b93eaaf. Read the comment docs.

@santiagobadia
Copy link
Member

@oriolcg can you solve the conflicts?

@oriolcg
Copy link
Member Author

oriolcg commented Mar 4, 2022

@oriolcg can you solve the conflicts?

Done in b93eaaf

@santiagobadia santiagobadia merged commit 92b58a1 into master Mar 5, 2022
@santiagobadia santiagobadia deleted the GridapODEs-_to_ODEs branch March 5, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants