Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended gradient for MultiField functionals involving Skeleton integration #799

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Extended gradient for MultiField functionals involving Skeleton integration #799

merged 5 commits into from
Jun 16, 2022

Conversation

kishore-nori
Copy link
Collaborator

@kishore-nori kishore-nori commented Jun 16, 2022

  • Refactored the existing MultiField functionals gradient code to make dispatch for Skeleton integration terms possible
  • Extended the MultiField functionals gradient for functionals involving Skeleton integration, in similar fashion as done for the SingleField case
  • Added tests to compare the results to that of ForwardDiff
  • Added tests for SkeletonCellFieldPair in the context of MultiField

@codecov-commenter
Copy link

Codecov Report

Merging #799 (eec591f) into master (56b97ea) will increase coverage by 0.01%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
+ Coverage   88.21%   88.22%   +0.01%     
==========================================
  Files         159      159              
  Lines       17716    17757      +41     
==========================================
+ Hits        15629    15667      +38     
- Misses       2087     2090       +3     
Impacted Files Coverage Δ
src/MultiField/MultiFieldFEAutodiff.jl 97.27% <92.00%> (-2.73%) ⬇️
src/MultiField/MultiFieldFESpaces.jl 80.70% <0.00%> (+0.39%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@amartinhuertas amartinhuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kishore-nori ! Thanks for the PR! Accepting it straight away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants