Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: get_normal_vector not correctly implemented for AdaptedTriangulations #884

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Mar 8, 2023

Fixes #883

@JordiManyer JordiManyer added the bug Something isn't working label Mar 8, 2023
@JordiManyer JordiManyer self-assigned this Mar 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #884 (af6b8af) into master (2765f2a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   88.57%   88.58%           
=======================================
  Files         172      172           
  Lines       20035    20037    +2     
=======================================
+ Hits        17746    17749    +3     
+ Misses       2289     2288    -1     
Impacted Files Coverage Δ
src/Adaptivity/AdaptedTriangulations.jl 82.75% <100.00%> (+0.20%) ⬆️
src/Geometry/Triangulations.jl 88.92% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amartinhuertas amartinhuertas merged commit be0dc01 into master Mar 8, 2023
@JordiManyer JordiManyer deleted the adapted-triangulations-normal-vectors branch March 15, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_normal_vector with AdaptedTriangulation (atop BoundaryTriangulation) fails
3 participants