Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorial constant fe space #888

Merged
merged 5 commits into from
May 19, 2023
Merged

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Mar 21, 2023

This PR fixes the definition of cell_dof_ids for the case of vectorial ConstantFESpace.

@oriolcg oriolcg added the bug Something isn't working label Mar 21, 2023
@oriolcg oriolcg self-assigned this Mar 21, 2023
@JordiManyer
Copy link
Member

@oriolcg I also get the CI errors in a PR I am currently preparing. I do not know where they come from, but I don't think it's linked to your PR. Also, all the tests run OK in my local computer. I have no idea where this might come from...

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #888 (1625a99) into master (be0dc01) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         172      172           
  Lines       20037    20037           
=======================================
  Hits        17749    17749           
  Misses       2288     2288           
Impacted Files Coverage Δ
src/FESpaces/ConstantFESpaces.jl 73.68% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@santiagobadia santiagobadia merged commit 6a0dfdd into master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants