Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing methods for LagrangianDofBasis #964

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

JordiManyer
Copy link
Member

Added the methods dof_to_node and dof_to_comp for LagragianDofBasis. These methods already existed for lagrangian ReferenceFEs and were already exported. I'm just expanding them for the dof basis as well.

@JordiManyer JordiManyer self-assigned this Dec 8, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5d369ef) 88.10% compared to head (3e86ff7) 88.10%.

Files Patch % Lines
src/ReferenceFEs/LagrangianDofBases.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   88.10%   88.10%   -0.01%     
==========================================
  Files         177      177              
  Lines       21075    21077       +2     
==========================================
  Hits        18569    18569              
- Misses       2506     2508       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer merged commit 10d0b59 into master Dec 8, 2023
7 checks passed
@JordiManyer JordiManyer deleted the dof-to-node-and-comp branch December 8, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants