Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-hyphen minus sign (Julia compatibility) #966

Closed
wants to merge 1 commit into from

Conversation

pmartorell
Copy link
Collaborator

Replacing the minus sign "−" (U+2212) to "-" (U+002D).

This PR improves backward compatibility of Julia. The sign "−" (U+2212) (\minus) is only available on Julia 1.7 or newer:

https://github.com/JuliaLang/julia/blob/v1.9.4/HISTORY.md#language-changes-1

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (10d0b59) 88.10% compared to head (5d718c4) 88.10%.

Files Patch % Lines
src/ODEs/ODETools/Tableaus.jl 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files         177      177           
  Lines       21077    21077           
=======================================
  Hits        18569    18569           
  Misses       2508     2508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer
Copy link
Member

@pmartorell The ODEs module is being refactored soon... I would wait for PR #965 to be merged before doing this.

@AlexandreMagueresse
Copy link
Collaborator

AlexandreMagueresse commented Dec 18, 2023

Hi @pmartorell , I had seen these nonstandard minus signs too and I replaced them when rewriting the ODE module in PR #965, more precisely here.

@pmartorell
Copy link
Collaborator Author

Thanks @AlexandreMagueresse, I close this PR since it is already considered in #965

@pmartorell pmartorell closed this Dec 19, 2023
@pmartorell pmartorell deleted the replace_minus_sign branch December 19, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants