adding TraceFEMTests.jl #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 19 19
Lines 1758 1758
=======================================
Hits 1540 1540
Misses 218 218
Continue to review full report at Codecov.
|
In release 0.17 will be possible to build a FESpace on a (body fitted) triangulation |
|
ah ok i see. Probably not the right time for this PR then. |
|
We can add it to the current version for the moment. No problem with this. |
fverdugo
requested changes
Oct 4, 2021
| @@ -0,0 +1,64 @@ | |||
| module TraceFEMTests | |||
|
|
|||
| using Gridap | |||
There was a problem hiding this comment.
This file is not being called by the CI
you need to include it in test/GridapEmbeddedTests/runtests.jl
fverdugo
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates relates to solving an equation ( in this case with no derivatives ) on a surface embedded in a volume. TraceFEM is used here for which the space used is the the space of traces of functions in the bulk FESpace on the boundary. Using this method, we can simply used the bulk FESpace restricted to cut cells, integrate along the
EmbeddedBoundaryand add some term for stability. This seems to work here, but in the new working branch the possibility to restrict aDiscreteModelis gone. The warning says to use a restricted Triangulation - but we cannot define a space based on a Triangulation. What is the alternative here if we want a space which only exists on a surface ?