Fix broken URL and add 1D test #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README's Observable URL was broken due to changes on Makie's docs site.
Adding 1D tests with a broken test for `scatter` (only for GLMakie). Also, the README make file includes replaceable url's.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 2 2
Lines 202 202
=======================================
Hits 188 188
Misses 14 14 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README's Observable URL was broken due to changes on Makie's docs site. I added a preprocessor for Literate.jl to add multiple version-dependent URLs. Besides, the addition of 1D test contains a broken test concerning
scatterandGLMakie(the test passes withCairoMakie).