Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gridap v0.15.1 #23

Merged
merged 23 commits into from
Mar 3, 2021
Merged

Conversation

ericneiva
Copy link
Member

Hi, @fverdugo, in this PR, I have accommodated GridapPETSc.jl to Gridap.jl at v0.15.1.

The only pending thing is to set the DOCUMENTER_KEY in gridap/GridapPETSc.jl.

Please, review and accept the changes whenever you have sometime.

@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #23 (178bba8) into master (04601b1) will decrease coverage by 3.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   85.26%   81.89%   -3.38%     
==========================================
  Files           7        7              
  Lines         224      243      +19     
==========================================
+ Hits          191      199       +8     
- Misses         33       44      +11     
Impacted Files Coverage Δ
src/GridapPETSc.jl 100.00% <ø> (ø)
src/LinearSolver.jl 100.00% <100.00%> (ø)
src/ksp.jl 78.26% <100.00%> (+3.26%) ⬆️
src/load.jl 90.32% <100.00%> (-2.79%) ⬇️
src/mat.jl 50.98% <100.00%> (-12.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04601b1...178bba8. Read the comment docs.

@ericneiva ericneiva closed this Feb 18, 2021
@ericneiva ericneiva reopened this Mar 2, 2021
@ericneiva
Copy link
Member Author

Hi, @fverdugo, I have reopened this PR.

The CI workflow runs with ubuntu 18.04 and x64 architectures, only.

Please, review and merge whenever you have some time.
Thanks!

@fverdugo fverdugo self-requested a review March 3, 2021 06:49
Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ericneiva thanks for your PR!

Just a question: the tests do not show any output in the GH Actions. Can you please check that they are executed correctly?

@ericneiva
Copy link
Member Author

Hi @ericneiva thanks for your PR!

Just a question: the tests do not show any output in the GH Actions. Can you please check that they are executed correctly?

I do not know why the CI output was truncated... I've run again the jobs and you should now see that the tests were carried out.

@ericneiva
Copy link
Member Author

ericneiva commented Mar 3, 2021

Hi @ericneiva thanks for your PR!
Just a question: the tests do not show any output in the GH Actions. Can you please check that they are executed correctly?

I do not know why the CI output was truncated... I've run again the jobs and you should now see that the tests were carried out.

Otherwise, you can check it by downloading the log file or viewing the raw logs.

@fverdugo fverdugo merged commit 9b7f925 into gridap:master Mar 3, 2021
@ericneiva ericneiva deleted the update_to_gridap_v0.15.1 branch March 3, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants