-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gridap v0.15.1 #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 85.26% 81.89% -3.38%
==========================================
Files 7 7
Lines 224 243 +19
==========================================
+ Hits 191 199 +8
- Misses 33 44 +11
Continue to review full report at Codecov.
|
Hi, @fverdugo, I have reopened this PR. The CI workflow runs with ubuntu 18.04 and x64 architectures, only. Please, review and merge whenever you have some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ericneiva thanks for your PR!
Just a question: the tests do not show any output in the GH Actions. Can you please check that they are executed correctly?
I do not know why the CI output was truncated... I've run again the jobs and you should now see that the tests were carried out. |
Otherwise, you can check it by downloading the log file or viewing the raw logs. |
Hi, @fverdugo, in this PR, I have accommodated
GridapPETSc.jl
toGridap.jl
at v0.15.1.The only pending thing is to set the
DOCUMENTER_KEY
ingridap/GridapPETSc.jl
.Please, review and accept the changes whenever you have sometime.