PetscLinearSolver partitioned mpi support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Poisson tests to test PETScLinearSolver in MPI mode. In this test, the "main" function, i.e., the one triggered from PArrays.prun, calls GridapPETSc.with(...). I am calling prun() twice within the same MPI context, and it did not give me any trouble.
amartinhuertas
changed the base branch from
master
to
partitioned_arrays_support
Codecov Report
@@ Coverage Diff @@
## partitioned_arrays_support #46 +/- ##
==============================================================
+ Coverage 87.80% 87.88% +0.08%
==============================================================
Files 9 9
Lines 738 743 +5
==============================================================
+ Hits 648 653 +5
Misses 90 90
Continue to review full report at Codecov.
|
fverdugo
approved these changes
Nov 5, 2021
fverdugo
deleted the
petsc_ksp_partitioned_simulations_mpi_mode_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be reviewed straight away, i.e., before PR #42.
@fverdugo ... note also the commit description. I could use
GridapPETSc.withwithin themainfunction triggered twice fromprunwithin the same MPI context, so that I did not actually need to explicitly callgridap_petsc_gc()at the end ofmain. (it is being called fromPETScFinalize()). I am not sure ... what do we have to solve here among the interplay ofprunandGridapPetsc.with(...)? (you mentioned something in Slack).