Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeMeasure integration not working properly in some cases #9

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

JordiManyer
Copy link
Member

PR for issue #8

@JordiManyer JordiManyer added the bug Something isn't working label Feb 20, 2023
@JordiManyer JordiManyer self-assigned this Feb 20, 2023
@JordiManyer JordiManyer linked an issue Feb 20, 2023 that may be closed by this pull request
@JordiManyer JordiManyer marked this pull request as ready for review February 21, 2023 05:29
@JordiManyer
Copy link
Member Author

This now works properly. We now get the same number of iterations with single processor runs and multi-processor runs.

@JordiManyer JordiManyer changed the title CompositeMeasure integration now working properly in some cases CompositeMeasure integration not working properly in some cases Feb 22, 2023
@JordiManyer JordiManyer merged commit 8425d6f into p4est-migration Feb 22, 2023
@JordiManyer JordiManyer deleted the bugfix-parallel-precision-loss branch February 22, 2023 01:10
@amartinhuertas
Copy link
Member

Fantastic! How much the number of iterations degrade with the number of levels for the optimal setting of the parameters? (Whatever this means)

@JordiManyer
Copy link
Member Author

Not much. We go from 17/18 iterations with 2 levels to 20 with 4/5 levels (in both single and multi processor runs).

@amartinhuertas
Copy link
Member

Can you let me know the setup of the algorithm to achieve that? I mean smoothers, number of smoothing steps per iteration etc.

@JordiManyer
Copy link
Member Author

JordiManyer commented Feb 22, 2023

It's this script: https://github.com/JordiManyer/GridapSolversBenchmark.jl/blob/e22c31d638f30a3a3577da5e22b22b8fb24b3a29/experiments/GMGSingleProc/run_experiment.jl

I have it run with 1 and 4 procs and get the same results (and I did not before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositeMeasure integration now working properly in some cases
2 participants